Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baz/source shopify/fix substream state filterring #34395

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Jan 20, 2024

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds then checking in your changes
  • Documentation which references the generator is updated as needed
Updating the Python CDK

Airbyter

Before merging:

  • Pull Request description explains what problem it is solving
  • Code change is unit tested
  • Build and my-py check pass
  • Smoke test the change on at least one affected connector
    • On Github: Run this workflow, passing --use-local-cdk --name=source-<connector> as options
    • Locally: airbyte-ci connectors --use-local-cdk --name=source-<connector> test
  • PR is reviewed and approved

After merging:

  • Publish the CDK
    • The CDK does not follow proper semantic versioning. Choose minor if this the change has significant user impact or is a breaking change. Choose patch otherwise.
    • Write a thoughtful changelog message so we know what was updated.
  • Merge the platform PR that was auto-created for updating the Connector Builder's CDK version
    • This step is optional if the change does not affect the connector builder or declarative connectors.

davinchia and others added 30 commits December 26, 2023 14:10
Co-authored-by: Ella Rohm-Ensing <[email protected]>
Co-authored-by: Tope Folorunso <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: alafanechere <[email protected]>
Co-authored-by: Aaron ("AJ") Steers <[email protected]>
…nested jooq function call sql. (#33877)

Signed-off-by: Gireesh Sreepathi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the api area/connectors Connector related issues area/platform issues related to the platform CDK Connector Development Kit connectors/destination/amazon-sqs connectors/destination/aws-datalake connectors/destination/azure-blob-storage connectors/destination/bigquery connectors/destination/bigquery-denormalized connectors/destination/cassandra connectors/destination/chroma connectors/destination/clickhouse connectors/destination/clickhouse-strict-encrypt connectors/destination/convex connectors/destination/csv connectors/destination/cumulio connectors/destination/databend connectors/destination/databricks connectors/destination/dev-null connectors/destination/doris connectors/destination/duckdb connectors/destination/dynamodb connectors/destination/e2e-test connectors/destination/elasticsearch connectors/destination/elasticsearch-strict-encryp connectors/destination/exasol connectors/destination/firebolt connectors/destination/firestore connectors/destination/gcs connectors/destination/google-sheets connectors/destination/iceberg connectors/destination/kafka connectors/destination/keen connectors/destination/kinesis connectors/destination/kvdb connectors/destination/langchain connectors/destination/local-json connectors/destination/mariadb-columnstore connectors/destination/meilisearch connectors/destination/milvus connectors/destination/mongodb connectors/destination/mongodb-strict-encrypt connectors/destination/mqtt connectors/destination/mssql connectors/destination/mssql-strict-encrypt connectors/destination/mysql connectors/destination/mysql-strict-encrypt connectors/destination/oracle connectors/destination/oracle-strict-encrypt connectors/destination/pinecone connectors/destination/postgres connectors/destination/postgres-strict-encrypt connectors/destination/pubsub connectors/destination/pulsar connectors/destination/qdrant connectors/destination/r2 connectors/destination/rabbitmq connectors/destination/redis connectors/destination/redpanda connectors/destination/redshift connectors/destination/rockset connectors/destination/s3-glue connectors/destination/s3 connectors/destination/scaffold-destination-python connectors/destination/scylla connectors/destination/selectdb connectors/destination/sftp-json connectors/destination/snowflake connectors/destination/sqlite connectors/destination/starburst-galaxy connectors/destination/teradata connectors/destination/tidb connectors/destination/timeplus connectors/destination/typesense connectors/destination/vectara connectors/destination/vertica connectors/destination/weaviate connectors/destination/xata connectors/destination/yugabytedb connectors/source/activecampaign connectors/source/adjust connectors/source/aha connectors/source/aircall connectors/source/airtable connectors/source/alloydb connectors/source/alloydb-strict-encrypt connectors/source/alpha-vantage connectors/source/amazon-ads connectors/source/amazon-seller-partner normalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.